chrome/browser/policy/policy_loader_win.cc - Issue 10830022: Fixed check return warnings from Coverity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/policy_loader_win.cc

Issue 10830022: Fixed check return warnings from Coverity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated per review comments. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/policy/policy_loader_win.cc

diff --git a/chrome/browser/policy/policy_loader_win.cc b/chrome/browser/policy/policy_loader_win.cc

index 36a44fea38450e53e1a55832ad4f4d7e2a503c2f..580f351da5a99bb5c445af21282b9bd9659a4de9 100644

--- a/chrome/browser/policy/policy_loader_win.cc

+++ b/chrome/browser/policy/policy_loader_win.cc

@@ -88,8 +88,8 @@ bool LoadHighestPriorityKey(const string16& key_path,

string16 path(kKeyPaths[k].path);

if (!key_path.empty())

path += kPathSep + key_path;

- key->Open(kHives[h].hive, path.c_str(), KEY_READ);

- if (!key->Valid())

+ if (key->Open(kHives[h].hive, path.c_str(), KEY_READ) != ERROR_SUCCESS ||

+ !key->Valid())

Joao da Silva 2012/07/26 16:19:02 Nit: add braces when the test or the body spans mo

Danh Nguyen 2012/07/26 17:08:05 Done.

continue;

if (value_name.empty() || key->HasValue(value_name.c_str())) {

*level = kKeyPaths[k].level;