Fixed check return warnings from Coverity.

chrome/browser/value_store/testing_value_store.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/value_store/testing_value_store.h"
 
 #include "base/logging.h"
 
 namespace {
 
@@ skipping 80 matching lines @@
 
 ValueStore::WriteResult TestingValueStore::Set(
     WriteOptions options, const DictionaryValue& settings) {
   if (fail_all_requests_) {
     return WriteResultError();
   }
 
   scoped_ptr<ValueStoreChangeList> changes(new ValueStoreChangeList());
   for (DictionaryValue::Iterator it(settings); it.HasNext(); it.Advance()) {
     Value* old_value = NULL;
-    storage_.GetWithoutPathExpansion(it.key(), &old_value);
+    bool rv = storage_.GetWithoutPathExpansion(it.key(), &old_value);
+    DCHECK(rv);

[Mattias Nissler (ping if slow), 2012/07/26 09:37:06]

Same thing, this may return false, in which case old_value is NULL, which is
handled properly in line 103.

     if (!old_value || !old_value->Equals(&it.value())) {

[Joao da Silva, 2012/07/26 10:04:33]

As Mattias mentioned, the DCHECK is wrong. Maybe rewrite this as:

if (!storage_.GetWithoutPathExpansion(it.key(), &old_value) ||
old_value->Equals(...)) { ... }

[Danh Nguyen, 2012/07/26 15:46:27]

Fixed.  Thanks Joao for your suggestion.

       changes->push_back(
           ValueStoreChange(
               it.key(),
               old_value ? old_value->DeepCopy() : old_value,
               it.value().DeepCopy()));
       storage_.SetWithoutPathExpansion(it.key(), it.value().DeepCopy());
     }
   }
   return MakeWriteResult(changes.release());
 }
@@ skipping 24 matching lines @@
   if (fail_all_requests_) {
     return WriteResultError();
   }
 
   std::vector<std::string> keys;
   for (DictionaryValue::Iterator it(storage_); it.HasNext(); it.Advance()) {
     keys.push_back(it.key());
   }
   return Remove(keys);
 }