Issue 10829255: Change the text of the "don't use inferred types" preference to "use inferred types" and invert the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829255: Change the text of the "don't use inferred types" preference to "use inferred types" and invert the… (Closed)

Created:
8 years, 4 months ago by devoncarew

Modified:
8 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Change the text of the "don't use inferred types" preference to "use inferred types" and invert the value. Committed: https://code.google.com/p/dart/source/detail?r=10442

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/DartAnalysisPreferencePage.java	View		5 chunks	+8 lines, -9 lines	0 comments	Download
	M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/PreferencesMessages.properties	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

devoncarew

Konstantin, the positive text ("use inferred type info") seems more natural to me then the ...

8 years, 4 months ago (2012-08-09 08:17:15 UTC) #1

scheglov

8 years, 4 months ago (2012-08-09 14:21:55 UTC) #2

LGTM
Commit it and I will remove negations and clean up users of this preference.