Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1366)

Unified Diff: content/browser/renderer_host/media/media_stream_device_settings.h

Issue 10829190: Resolve the problems where we can leak the system tray UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased and addressed the comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/media_stream_device_settings.h
diff --git a/content/browser/renderer_host/media/media_stream_device_settings.h b/content/browser/renderer_host/media/media_stream_device_settings.h
index 34592b037c987362ce8bfaec7154dc467a1eb245..9b9fde890b83adaf8655afad5862b4b4a3473a2f 100644
--- a/content/browser/renderer_host/media/media_stream_device_settings.h
+++ b/content/browser/renderer_host/media/media_stream_device_settings.h
@@ -74,13 +74,16 @@ class CONTENT_EXPORT MediaStreamDeviceSettings {
// view.
bool IsUiBusy(int render_view_id, int render_process_id);
- // Finds a request ready to be sent to UI for user approval.
- std::string FindReadyRequestForView(int render_view_id,
- int render_process_id);
+ // Process the next pending request and bring it up to the UI on the given
+ // page for user approval.
+ void ProcessNextRequestForView(int render_view_id, int render_process_id);
// Posts a request to be approved/denied by UI.
void PostRequestToUi(const std::string& label);
+ // Posts a request to fake UI which is used for testing purpose.
+ void PostRequestToFakeUI(const std::string& label);
scherkus (not reviewing) 2012/08/13 19:51:22 nit: there's a mix of UI and Ui in this class -- w
no longer working on chromium 2012/08/14 11:17:04 Done.
+
SettingsRequester* requester_;
SettingsRequests requests_;

Powered by Google App Engine
This is Rietveld 408576698