Resolve the problems where we can leak the system tray UI

content/browser/renderer_host/media/media_stream_device_settings.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // MediaStreamDeviceSettings is used to decide which of the available capture
 // device to use as well as getting user permission to use the capture device.
 // There will be one instance of MediaStreamDeviceSettings handling all
 // requests.
 
 // Expected call flow:
@@ skipping 56 matching lines @@
   void UseFakeUI();
 
  private:
   typedef std::map<std::string, MediaStreamDeviceSettingsRequest*>
       SettingsRequests;
 
   // Returns true if the UI is already processing a request for this render
   // view.
   bool IsUiBusy(int render_view_id, int render_process_id);
 
-  // Finds a request ready to be sent to UI for user approval.
-  std::string FindReadyRequestForView(int render_view_id,
-                                      int render_process_id);
+  // Process the next pending request and bring it up to the UI on the given
+  // page for user approval.
+  void ProcessNextRequestForView(int render_view_id, int render_process_id);
 
   // Posts a request to be approved/denied by UI.
   void PostRequestToUi(const std::string& label);
 
+  // Posts a request to fake UI which is used for testing purpose.
+  void PostRequestToFakeUI(const std::string& label);

[scherkus (not reviewing), 2012/08/13 19:51:22]

nit: there's a mix of UI and Ui in this class -- which one should it be?

[no longer working on chromium, 2012/08/14 11:17:04]

Done.

+
   SettingsRequester* requester_;
   SettingsRequests requests_;
 
   // See comment above for method UseFakeUI. Used for automated testing.
   bool use_fake_ui_;
 
   base::WeakPtrFactory<MediaStreamDeviceSettings> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaStreamDeviceSettings);
 };
 
 }  // namespace media_stream
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_MEDIA_MEDIA_STREAM_DEVICE_SETTINGS_H_