Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 10829188: Use net::UploadDataStream::Init() instead of InitSync() (Closed)

Created:
8 years, 4 months ago by hashimoto
Modified:
8 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Use net::UploadDataStream::Init() instead of InitSync() BUG=113669 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157512

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : address review comments #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
M net/http/http_network_transaction.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 2 3 4 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
This change depends on http://codereview.chromium.org/10823180/
8 years, 4 months ago (2012-08-06 08:48:37 UTC) #1
hashimoto
Eric, could you review this change?
8 years, 4 months ago (2012-08-08 03:29:54 UTC) #2
eroman
lgtm http://codereview.chromium.org/10829188/diff/1/net/http/http_network_transaction.cc File net/http/http_network_transaction.cc (right): http://codereview.chromium.org/10829188/diff/1/net/http/http_network_transaction.cc#newcode755 net/http/http_network_transaction.cc:755: int error_code = OK; nit: for consistency you ...
8 years, 4 months ago (2012-08-08 19:06:01 UTC) #3
hashimoto
Thank you for reviewing. Could you review http://codereview.chromium.org/10823180/ too? This change depends on that. http://codereview.chromium.org/10829188/diff/1/net/http/http_network_transaction.cc ...
8 years, 4 months ago (2012-08-09 04:35:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10829188/15001
8 years, 3 months ago (2012-09-19 04:01:15 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 05:51:14 UTC) #6
Change committed as 157512

Powered by Google App Engine
This is Rietveld 408576698