Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: content/public/browser/navigation_entry.h

Issue 10829044: Implement NavigationControllerWebView.PostURL (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixes according to comments. Improve render_view test. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_entry.h
diff --git a/content/public/browser/navigation_entry.h b/content/public/browser/navigation_entry.h
index ddbc1d0214c7d99d395c8006eb09f85088588ac0..247cb4a21c19aba1982a07ba23e63e4450e0d9b2 100644
--- a/content/public/browser/navigation_entry.h
+++ b/content/public/browser/navigation_entry.h
@@ -6,6 +6,7 @@
#define CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_
#include <string>
+#include <vector>
#include "base/string16.h"
#include "content/common/content_export.h"
@@ -125,8 +126,10 @@ class NavigationEntry {
// have to be reposted to reload the page properly. This flag indicates
// whether the page had post data.
//
- // The actual post data is stored in the content_state and is extracted by
- // WebKit to actually make the request.
+ // The actual post data is stored either in
+ // 1) browser_initiated_post_data when a new post data request is started.
+ // 2) content_state when a post request has started and is extracted by
+ // WebKit to actually make the request.
virtual void SetHasPostData(bool has_post_data) = 0;
virtual bool GetHasPostData() const = 0;
@@ -134,6 +137,13 @@ class NavigationEntry {
virtual void SetPostID(int64 post_id) = 0;
virtual int64 GetPostID() const = 0;
+ // Holds the raw post data of a browser initiated post request.
+ // For efficiency, this should be cleared when content_state is populated
+ // since the data is duplicated. Note this is not persisted in session
+ // restore.
+ virtual void SetBrowserInitiatedPostData(const std::vector<char>& data) = 0;
+ virtual const std::vector<char>& GetBrowserInitiatedPostData() const = 0;
joth 2012/07/27 23:12:38 Hmmm rather than pull in 'vector' another option w
boliu 2012/07/27 23:17:36 Does RefCountedMemory work with IPC? This data cro
jam 2012/07/27 23:36:15 no. you can send shared memory though. who genera
+
// The favicon data and tracking information. See content::FaviconStatus.
virtual const FaviconStatus& GetFavicon() const = 0;
virtual FaviconStatus& GetFavicon() = 0;

Powered by Google App Engine
This is Rietveld 408576698