Implement NavigationControllerWebView.PostURL

content/public/browser/navigation_entry.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_
 
 #include <string>
+#include <vector>
 
 #include "base/string16.h"
 #include "content/common/content_export.h"
 #include "content/public/common/page_transition_types.h"
 #include "content/public/common/page_type.h"
 #include "content/public/common/referrer.h"
 
 class GURL;
 
 namespace content {
@@ skipping 99 matching lines @@
   // the name that the user things of the site as having.
   //
   // This URL will be is_empty() if the URL was navigated to some other way.
   // Callers should fall back on using the regular or display URL in this case.
   virtual const GURL& GetUserTypedURL() const = 0;
 
   // Post data is form data that was posted to get to this page. The data will
   // have to be reposted to reload the page properly. This flag indicates
   // whether the page had post data.
   //
-  // The actual post data is stored in the content_state and is extracted by
-  // WebKit to actually make the request.
+  // The actual post data is stored either in
+  // 1) browser_initiated_post_data when a new post data request is started.
+  // 2) content_state when a post request has started and is extracted by
+  //    WebKit to actually make the request.
   virtual void SetHasPostData(bool has_post_data) = 0;
   virtual bool GetHasPostData() const = 0;
 
   // The Post identifier associated with the page.
   virtual void SetPostID(int64 post_id) = 0;
   virtual int64 GetPostID() const = 0;
 
+  // Holds the raw post data of a browser initiated post request.
+  // For efficiency, this should be cleared when content_state is populated
+  // since the data is duplicated. Note this is not persisted in session
+  // restore.
+  virtual void SetBrowserInitiatedPostData(const std::vector<char>& data) = 0;
+  virtual const std::vector<char>& GetBrowserInitiatedPostData() const = 0;

[joth, 2012/07/27 23:12:38]

Hmmm rather than pull in 'vector' another option would be to use
base::RefCountedMemory, as this allows the client to choose the most convenient
container and easily avoids a couple of the copies along the line.
(it also allows a nice differentiation of empty vs null data)

Up to the API OWNERS whether that's a concept they'd like included here?

[boliu, 2012/07/27 23:17:36]

Does RefCountedMemory work with IPC? This data crosses IPC boundary , and git
grep RefCountedMemory | grep IPC didn't find an instance where it's used for IPC
messages.

[jam, 2012/07/27 23:36:15]

no. you can send shared memory though.

who generates this browser-initiated posts? i.e. how big can it be? if it's in
the MBs, it should be sent over IPC as shared memory.

+
   // The favicon data and tracking information. See content::FaviconStatus.
   virtual const FaviconStatus& GetFavicon() const = 0;
   virtual FaviconStatus& GetFavicon() = 0;
 
   // All the SSL flags and state. See content::SSLStatus.
   virtual const SSLStatus& GetSSL() const = 0;
   virtual SSLStatus& GetSSL() = 0;
 
   // Store the URL that caused this NavigationEntry to be created.
   virtual void SetOriginalRequestURL(const GURL& original_url) = 0;
   virtual const GURL& GetOriginalRequestURL() const = 0;
 
   // Store whether or not we're overriding the user agent.
   virtual void SetIsOverridingUserAgent(bool override) = 0;
   virtual bool GetIsOverridingUserAgent() const = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_