[sync] Refactor how default sync datatypes are set.

chrome/browser/prefs/browser_prefs.cc

Index: chrome/browser/prefs/browser_prefs.cc
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index d7f1634e5580b2d523638019285b7172571101bb..668aa2754fc53da23cab33a1d4fe052e53eba050 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -239,13 +239,14 @@ void RegisterUserPrefs(PrefService* user_prefs) {
   ash::RegisterChromeLauncherUserPrefs(user_prefs);
 #endif
 
+  extensions::ExtensionPrefs::RegisterUserPrefs(user_prefs);

[akalin, 2012/08/07 00:49:05]

out of curiosity, where exactly is this needed?  i.e. what code that is run on
android is looking at the extension prefs?

[nilesh, 2012/08/07 16:42:16]

extensions::ExtensionSystem::Get() causes ExtensionSystem to be created.
ExtensionSystemImpl reads extension prefs during initialization.

One such call is in
ProfileSyncComponentsFactoryImpl::ProfileSyncComponentsFactoryImpl()

[nilesh, 2012/08/07 17:10:43]

Tommy, please move this up with the default ones.

+
 #if !defined(OS_ANDROID)
   AppsPromo::RegisterUserPrefs(user_prefs);
   CaptureVisibleTabFunction::RegisterUserPrefs(user_prefs);
   ChromeToMobileService::RegisterUserPrefs(user_prefs);
   extensions::CommandService::RegisterUserPrefs(user_prefs);
   extensions::ComponentLoader::RegisterUserPrefs(user_prefs);
-  extensions::ExtensionPrefs::RegisterUserPrefs(user_prefs);
   ExtensionSettingsHandler::RegisterUserPrefs(user_prefs);
   RegisterBrowserUserPrefs(user_prefs);
   RegisterAutolaunchPrefs(user_prefs);