[sync] Refactor how default sync datatypes are set.

chrome/browser/prefs/browser_prefs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/browser_prefs.h"
 
 #include "chrome/browser/about_flags.h"
 #include "chrome/browser/accessibility/invert_bubble_prefs.h"
 #include "chrome/browser/autofill/autofill_manager.h"
 #include "chrome/browser/background/background_mode_manager.h"
@@ skipping 221 matching lines @@
 #endif
 
 #if defined(OS_ANDROID)
   geolocation::RegisterUserPrefs(user_prefs);
 #endif
 
 #if defined(USE_ASH)
   ash::RegisterChromeLauncherUserPrefs(user_prefs);
 #endif
 
+  extensions::ExtensionPrefs::RegisterUserPrefs(user_prefs);

[akalin, 2012/08/07 00:49:05]

out of curiosity, where exactly is this needed?  i.e. what code that is run on
android is looking at the extension prefs?

[nilesh, 2012/08/07 16:42:16]

extensions::ExtensionSystem::Get() causes ExtensionSystem to be created.
ExtensionSystemImpl reads extension prefs during initialization.

One such call is in
ProfileSyncComponentsFactoryImpl::ProfileSyncComponentsFactoryImpl()

[nilesh, 2012/08/07 17:10:43]

Tommy, please move this up with the default ones.

+
 #if !defined(OS_ANDROID)
   AppsPromo::RegisterUserPrefs(user_prefs);
   CaptureVisibleTabFunction::RegisterUserPrefs(user_prefs);
   ChromeToMobileService::RegisterUserPrefs(user_prefs);
   extensions::CommandService::RegisterUserPrefs(user_prefs);
   extensions::ComponentLoader::RegisterUserPrefs(user_prefs);
-  extensions::ExtensionPrefs::RegisterUserPrefs(user_prefs);
   ExtensionSettingsHandler::RegisterUserPrefs(user_prefs);
   RegisterBrowserUserPrefs(user_prefs);
   RegisterAutolaunchPrefs(user_prefs);
   DevToolsWindow::RegisterUserPrefs(user_prefs);
   PepperFlashSettingsManager::RegisterUserPrefs(user_prefs);
   PinnedTabCodec::RegisterUserPrefs(user_prefs);
   PluginsUI::RegisterUserPrefs(user_prefs);
   SyncPromoUI::RegisterUserPrefs(user_prefs);
   printing::StickySettings::RegisterUserPrefs(user_prefs);
 #endif
@@ skipping 73 matching lines @@
     }
     local_state->ClearPref(prefs::kLastPromptedGoogleURL);
 
     current_version |= GOOGLE_URL_TRACKER_PREFS;
     local_state->SetInteger(prefs::kMultipleProfilePrefMigration,
                             current_version);
   }
 }
 
 }  // namespace chrome