Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10828328: Expose EXT_debug_marker to webkit (Closed)

Created:
8 years, 4 months ago by greggman
Modified:
8 years, 4 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
greggman
Hey Al, PTAL
8 years, 4 months ago (2012-08-15 18:26:32 UTC) #1
apatrick_chromium
lgtm http://codereview.chromium.org/10828328/diff/1/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h File content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h (right): http://codereview.chromium.org/10828328/diff/1/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h#newcode587 content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h:587: virtual void popGroupMarkerEXT(void); (void) -> () http://codereview.chromium.org/10828328/diff/1/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h File ...
8 years, 4 months ago (2012-08-15 18:53:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10828328/6001
8 years, 4 months ago (2012-08-15 18:59:34 UTC) #3
commit-bot: I haz the power
Try job failure for 10828328-6001 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-15 21:11:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10828328/6001
8 years, 4 months ago (2012-08-16 00:17:09 UTC) #5
commit-bot: I haz the power
Try job failure for 10828328-6001 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-16 01:42:53 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-23 00:34:47 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698