Preprocessing version number for plugins to ignore leading zeros during comparisons. This eliminate…

webkit/plugins/npapi/plugin_group_unittest.cc

Index: webkit/plugins/npapi/plugin_group_unittest.cc
===================================================================
--- webkit/plugins/npapi/plugin_group_unittest.cc	(revision 151240)
+++ webkit/plugins/npapi/plugin_group_unittest.cc	(working copy)
@@ -27,12 +27,14 @@
     { "10.3 d180", "10.3.180" },       // Flash (Debug)
     { "11.5.7r609", "11.5.7.609"},     // Shockwave
     { "1.6.0_22", "1.6.0.22"},         // Java
+    { "1.07.00_0005", "1.7.0.5"}       // Java with leading zeros
   };
 
   for (size_t i = 0; i < arraysize(versions); i++) {
     Version version;
     PluginGroup::CreateVersionFromString(ASCIIToUTF16(versions[i][0]),
                                          &version);
+

[Bernhard Bauer, 2012/08/13 11:25:43]

Could you add an ASSERT here that the parsed version is valid?

[ibraaaa, 2012/08/13 12:26:45]

Done.

[Bernhard Bauer, 2012/08/13 12:31:12]

Can you change it to an ASSERT_TRUE? (The reason I'm asking is that
Version::GetString() DCHECKs that it is valid, which would cause a crash. ASSERT
aborts the test before that.)

[ibraaaa, 2012/08/13 12:39:35]

Done.

     EXPECT_EQ(versions[i][1], version.GetString());
   }
 }