Preprocessing version number for plugins to ignore leading zeros during comparisons. This eliminate…

webkit/plugins/npapi/plugin_group_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/npapi/plugin_group.h"
 
 #include <string>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/utf_string_conversions.h"
 #include "base/version.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace webkit {
 namespace npapi {
 
 TEST(PluginGroupTest, VersionExtraction) {
   // Some real-world plugin versions (spaces, commata, parentheses, 'r', oh my)
   const char* versions[][2] = {
     { "7.6.6 (1671)", "7.6.6.1671" },  // Quicktime
     { "2, 0, 0, 254", "2.0.0.254" },   // DivX
     { "3, 0, 0, 0", "3.0.0.0" },       // Picasa
     { "1, 0, 0, 1", "1.0.0.1" },       // Earth
     { "10,0,45,2", "10.0.45.2" },      // Flash
     { "10.1 r102", "10.1.102"},        // Flash
     { "10.3 d180", "10.3.180" },       // Flash (Debug)
     { "11.5.7r609", "11.5.7.609"},     // Shockwave
     { "1.6.0_22", "1.6.0.22"},         // Java
+    { "1.07.00_0005", "1.7.0.5"}       // Java with leading zeros
   };
 
   for (size_t i = 0; i < arraysize(versions); i++) {
     Version version;
     PluginGroup::CreateVersionFromString(ASCIIToUTF16(versions[i][0]),
                                          &version);
+

[Bernhard Bauer, 2012/08/13 11:25:43]

Could you add an ASSERT here that the parsed version is valid?

[ibraaaa, 2012/08/13 12:26:45]

Done.

[Bernhard Bauer, 2012/08/13 12:31:12]

Can you change it to an ASSERT_TRUE? (The reason I'm asking is that
Version::GetString() DCHECKs that it is valid, which would cause a crash. ASSERT
aborts the test before that.)

[ibraaaa, 2012/08/13 12:39:35]

Done.

     EXPECT_EQ(versions[i][1], version.GetString());
   }
 }
 
 }  // namespace npapi
 }  // namespace webkit