Allow platform apps to respond to Web Intents

chrome/browser/ui/intents/web_intent_picker_controller.cc

Index: chrome/browser/ui/intents/web_intent_picker_controller.cc
diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.cc b/chrome/browser/ui/intents/web_intent_picker_controller.cc
index 38eb5f2e0019f76a62e0aa1adc8e8e561609b313..c8ef4bfe8a71cfa2a64cf6ea583da54d1f87fdfb 100644
--- a/chrome/browser/ui/intents/web_intent_picker_controller.cc
+++ b/chrome/browser/ui/intents/web_intent_picker_controller.cc
@@ -287,11 +287,7 @@ void WebIntentPickerController::OnServiceChosen(const GURL& url,
   const extensions::Extension* extension = service->GetInstalledApp(url);
   if (extension && extension->is_platform_app()) {
     extensions::LaunchPlatformAppWithWebIntent(tab_contents_->profile(),
-        extension, intents_dispatcher_->GetIntent());
-    // TODO(benwells): hook up return pathway to allow platform app to post
-    // success or failure.
-    intents_dispatcher_->SendReplyMessage(
-        webkit_glue::WEB_INTENT_REPLY_SUCCESS, string16());
+        extension, intents_dispatcher_);

[koz (OOO until 15th September), 2012/08/08 04:47:30]

Hm. So looking at the code below a bit more it seems that there are a few things
we need to consider

- when the source tab gets closed, we need to clean up
- if the app gets suspended or uninstalled, we need to clean up

When the source tab is closed I wonder if we can just kill the mapping and
ignore any responses from the app.

When the app gets suspended, it will lose its JS reference, and thus any ability
to respond to this web intent, so in that case we can also just kill the
mapping, and we'd need to notify the source tab that this has happened.

[thorogood, 2012/08/08 07:15:49]

We'd need to call postFailure with null, which is what happens in other cases
(there's no "magic message" used for different circumstances).

so, I agree to all this: I'm going to dig around (or ask you) how to do these
things, but not in this immediate reply batch.

     ClosePicker();
     return;
   }