Allow platform apps to respond to Web Intents

chrome/browser/ui/intents/web_intent_picker_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/intents/web_intent_picker_controller.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 269 matching lines @@
   ClosePicker();
 }
 
 void WebIntentPickerController::OnServiceChosen(const GURL& url,
                                                 Disposition disposition) {
   ExtensionService* service = tab_contents_->profile()->GetExtensionService();
   DCHECK(service);
   const extensions::Extension* extension = service->GetInstalledApp(url);
   if (extension && extension->is_platform_app()) {
     extensions::LaunchPlatformAppWithWebIntent(tab_contents_->profile(),
-        extension, intents_dispatcher_->GetIntent());
-    // TODO(benwells): hook up return pathway to allow platform app to post
-    // success or failure.
-    intents_dispatcher_->SendReplyMessage(
-        webkit_glue::WEB_INTENT_REPLY_SUCCESS, string16());
+        extension, intents_dispatcher_);

[koz (OOO until 15th September), 2012/08/08 04:47:30]

Hm. So looking at the code below a bit more it seems that there are a few things
we need to consider

- when the source tab gets closed, we need to clean up
- if the app gets suspended or uninstalled, we need to clean up

When the source tab is closed I wonder if we can just kill the mapping and
ignore any responses from the app.

When the app gets suspended, it will lose its JS reference, and thus any ability
to respond to this web intent, so in that case we can also just kill the
mapping, and we'd need to notify the source tab that this has happened.

[thorogood, 2012/08/08 07:15:49]

We'd need to call postFailure with null, which is what happens in other cases
(there's no "magic message" used for different circumstances).

so, I agree to all this: I'm going to dig around (or ask you) how to do these
things, but not in this immediate reply batch.

     ClosePicker();
     return;
   }
 
   switch (disposition) {
     case WebIntentPickerModel::DISPOSITION_INLINE:
       // Set the model to inline disposition. It will notify the picker which
       // will respond (via OnInlineDispositionWebContentsCreated) with the
       // WebContents to dispatch the intent to.
       picker_model_->SetInlineDisposition(url);
@@ skipping 463 matching lines @@
   // If picker is non-NULL, it was set by a test.
   if (picker_ == NULL)
     picker_ = WebIntentPicker::Create(tab_contents_, this, picker_model_.get());
   picker_shown_ = true;
 }
 
 void WebIntentPickerController::ClosePicker() {
   if (picker_)
     picker_->Close();
 }