Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5784)

Unified Diff: chrome/browser/extensions/api/push_messaging/invalidation_handler_observer.h

Issue 10828087: Add skeleton implementation of ExtensionPushMessagingEventRouter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Docs Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/push_messaging/invalidation_handler_observer.h
diff --git a/chrome/browser/extensions/api/push_messaging/invalidation_handler_observer.h b/chrome/browser/extensions/api/push_messaging/invalidation_handler_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..74082339d7eeecf5f631f27d4965b18bece93a4e
--- /dev/null
+++ b/chrome/browser/extensions/api/push_messaging/invalidation_handler_observer.h
@@ -0,0 +1,22 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_INVALIDATION_HANDLER_OBSERVER_H_
Munjal (Google) 2012/07/31 17:36:12 I think Pete is using api/push/ folder in another
dcheng 2012/07/31 19:04:11 He's OOO this week. However, I talked to Mark abou
Munjal (Google) 2012/07/31 23:09:58 Okay, SG.
+#define CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_INVALIDATION_HANDLER_OBSERVER_H_
+
+#include <string>
+
+namespace extensions {
+
+class InvalidationHandlerObserver {
Munjal (Google) 2012/07/31 17:36:12 It will be nice to have a description for this cla
dcheng 2012/07/31 19:04:11 Done.
+ public:
+ virtual ~InvalidationHandlerObserver() {}
+ virtual void OnMessage(const std::string& extension_id,
+ int subchannel,
Munjal (Google) 2012/07/31 17:36:12 Nit: sub_channel?
dcheng 2012/07/31 19:04:11 I ended up picking subchannel since "subchannel" i
+ const std::string& payload) = 0;
+};
Munjal (Google) 2012/07/31 17:36:12 Nit: I am not sure if we need DISALLOW_COPY_AND_AS
dcheng 2012/07/31 19:04:11 I took a look at several other pure virtual classe
+
+} // namespace extensions
+
+#endif // CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_INVALIDATION_HANDLER_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698