chrome/browser/extensions/api/push_messaging/invalidation_handler_observer.h - Issue 10828087: Add skeleton implementation of ExtensionPushMessagingEventRouter.

Side by Side Diff: chrome/browser/extensions/api/push_messaging/invalidation_handler_observer.h

Issue 10828087: Add skeleton implementation of ExtensionPushMessagingEventRouter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Docs Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | chrome/browser/extensions/api/push_messaging/push_messaging_api.h » ('j') | chrome/browser/extensions/api/push_messaging/push_messaging_api.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_INVALIDATION_HANDLER_OBSERV ER_H_
	Munjal (Google) 2012/07/31 17:36:12 I think Pete is using api/push/ folder in another I think Pete is using api/push/ folder in another patch. Can you sync up with him about the folder? dcheng 2012/07/31 19:04:11 He's OOO this week. However, I talked to Mark abou Show quoted text On 2012/07/31 17:36:12, munjal wrote: > I think Pete is using api/push/ folder in another patch. Can you sync up with > him about the folder? He's OOO this week. However, I talked to Mark about this and since we're planning on calling it "push messaging", I made it consistent throughout the code, documentation and file paths. Munjal (Google) 2012/07/31 23:09:58 Okay, SG. Show quoted text On 2012/07/31 19:04:11, dcheng wrote: > On 2012/07/31 17:36:12, munjal wrote: > > I think Pete is using api/push/ folder in another patch. Can you sync up with > > him about the folder? > > He's OOO this week. However, I talked to Mark about this and since we're > planning on calling it "push messaging", I made it consistent throughout the > code, documentation and file paths. Okay, SG.
	6 #define CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_INVALIDATION_HANDLER_OBSERV ER_H_

	7

	8 #include <string>

	9

	10 namespace extensions {

	11

	12 class InvalidationHandlerObserver {
	Munjal (Google) 2012/07/31 17:36:12 It will be nice to have a description for this cla It will be nice to have a description for this class. dcheng 2012/07/31 19:04:11 Done. Show quoted text On 2012/07/31 17:36:12, munjal wrote: > It will be nice to have a description for this class. Done.
	13 public:

	14 virtual ~InvalidationHandlerObserver() {}

	15 virtual void OnMessage(const std::string& extension_id,

	16 int subchannel,
	Munjal (Google) 2012/07/31 17:36:12 Nit: sub_channel? Nit: sub_channel? dcheng 2012/07/31 19:04:11 I ended up picking subchannel since "subchannel" i Show quoted text On 2012/07/31 17:36:12, munjal wrote: > Nit: sub_channel? I ended up picking subchannel since "subchannel" is a more popular term than "sub channel", in both Google search (from what I could tell) and code search.
	17 const std::string& payload) = 0;

	18 };
	Munjal (Google) 2012/07/31 17:36:12 Nit: I am not sure if we need DISALLOW_COPY_AND_AS Nit: I am not sure if we need DISALLOW_COPY_AND_ASSIGN for abstract classes. May be it is good to add it? dcheng 2012/07/31 19:04:11 I took a look at several other pure virtual classe Show quoted text On 2012/07/31 17:36:12, munjal wrote: > Nit: I am not sure if we need DISALLOW_COPY_AND_ASSIGN for abstract classes. May > be it is good to add it? I took a look at several other pure virtual classes, and none of them used DISALLOW_COPY_AND_ASSIGN (content::NotificationObserver, syncer::SyncNotifierObserver, several in base/)
	19

	20 } // namespace extensions

	21

	22 #endif // CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_INVALIDATION_HANDLER_OBS ERVER_H_

OLD	NEW