File Manager: fix an unsafe const reference (intermittent crash).

chrome/browser/chromeos/extensions/file_browser_private_api.cc

Index: chrome/browser/chromeos/extensions/file_browser_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/file_browser_private_api.cc b/chrome/browser/chromeos/extensions/file_browser_private_api.cc
index b4f46d81609fc82c7505cdb0bdef08e49fcf14e3..1fa6ae3a1e35f2300183ff6697062d11b8bf967a 100644
--- a/chrome/browser/chromeos/extensions/file_browser_private_api.cc
+++ b/chrome/browser/chromeos/extensions/file_browser_private_api.cc
@@ -1152,7 +1152,7 @@ void AddMountFunction::GetLocalPathsResponseOnUIThread(
   }
 
   const FilePath& source_path = files[0].local_path;
-  const FilePath::StringType& display_name =
+  const FilePath::StringType display_name =
       files[0].file_path.BaseName().value();

[tbarzic, 2012/07/31 01:00:25]

yeah, this is my fault.. I forgot to undo some experimentation I did in
http://crrev.com/148492

I think files[0].display_name should work (even with the reference).

[hshi1, 2012/07/31 01:04:41]

Ah I see so it IS a regression after all... would Patch#2 work for you? Thanks.

On 2012/07/31 01:00:25, tbarzic wrote:

   // Check if the source path is under GData cache directory.
   gdata::GDataSystemService* system_service =