File Manager: fix an unsafe const reference (intermittent crash).

chrome/browser/chromeos/extensions/file_browser_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_browser_private_api.h"
 
 #include <utility>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 1134 matching lines @@
     const std::string& mount_type_str,
     const SelectedFileInfoList& files) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   if (!files.size()) {
     SendResponse(false);
     return;
   }
 
   const FilePath& source_path = files[0].local_path;
-  const FilePath::StringType& display_name =
+  const FilePath::StringType display_name =
       files[0].file_path.BaseName().value();

[tbarzic, 2012/07/31 01:00:25]

yeah, this is my fault.. I forgot to undo some experimentation I did in
http://crrev.com/148492

I think files[0].display_name should work (even with the reference).

[hshi1, 2012/07/31 01:04:41]

Ah I see so it IS a regression after all... would Patch#2 work for you? Thanks.

On 2012/07/31 01:00:25, tbarzic wrote:

   // Check if the source path is under GData cache directory.
   gdata::GDataSystemService* system_service =
       gdata::GDataSystemServiceFactory::GetForProfile(profile_);
   gdata::GDataCache* cache = system_service ? system_service->cache() : NULL;
   if (cache && cache->IsUnderGDataCacheDirectory(source_path)) {
     cache->SetMountedStateOnUIThread(
         source_path,
         true,
         base::Bind(&AddMountFunction::OnMountedStateSet, this, mount_type_str,
                    display_name));
@@ skipping 1247 matching lines @@
   gdata::GDataSystemService* system_service =
       gdata::GDataSystemServiceFactory::GetForProfile(profile_);
   if (!system_service || !system_service->file_system())
     return false;
 
   FilePath directory_path = GetVirtualPathFromURL(GURL(file_url_as_string));
   system_service->file_system()->RequestDirectoryRefresh(directory_path);
 
   return true;
 }