Issue 10828025: Added sanity check for entry in SparseControl::DeleteChildren

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828025: Added sanity check for entry in SparseControl::DeleteChildren (Closed)

Created:
8 years, 5 months ago by Oren Blasberg

Modified:
8 years, 5 months ago

Reviewers:
rvargas (doing something else), James Hawkins

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, gavinp+disk_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Added sanity check for entry in ReadyToUse CID_COUNT=1 CID=103693 BUG= TEST= TBR=rvargas Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148457

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	net/disk_cache/sparse_control.cc	View		2 chunks	+2 lines, -1 line	1 comment	Download

Total messages: 5 (0 generated)

Oren Blasberg

I added a sanity check for 'entry' via DCHECK in SparseControl::DeleteChildren. Static analysis had revealed ...

8 years, 5 months ago (2012-07-25 23:34:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/orenb@chromium.org/10828025/1

8 years, 5 months ago (2012-07-25 23:38:29 UTC) #3

rvargas (doing something else)

If you add someone to a code review, please wait until that person actually sees ...

8 years, 5 months ago (2012-07-26 00:03:14 UTC) #4

Change committed as 148457