Added sanity check for entry in SparseControl::DeleteChildren

net/disk_cache/sparse_control.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/disk_cache/sparse_control.h"
 
 #include "base/bind.h"
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
@@ skipping 314 matching lines @@
   // We'll grab another reference to keep this object alive because we just have
   // one extra reference due to the pending IO operation itself, but we'll
   // release that one before invoking user_callback_.
   entry_->AddRef();  // Balanced in DoAbortCallbacks.
   abort_callbacks_.push_back(callback);
   return net::ERR_IO_PENDING;
 }
 
 // Static
 void SparseControl::DeleteChildren(EntryImpl* entry) {
+  DCHECK(entry);

[rvargas (doing something else), 2012/07/26 00:03:14]

Actually, removing the DCHECK makes more sense. We usually don't DCHECK the
arguments on internal calls.

   DCHECK(entry->GetEntryFlags() & PARENT_ENTRY);
   int data_len = entry->GetDataSize(kSparseIndex);
   if (data_len < static_cast<int>(sizeof(SparseData)) ||
       entry->GetDataSize(kSparseData))
     return;
 
   int map_len = data_len - sizeof(SparseHeader);
   if (map_len > kMaxMapSize || map_len % 4)
     return;
 
   char* buffer;
   Addr address;
   entry->GetData(kSparseIndex, &buffer, &address);
   if (!buffer && !address.is_initialized())
     return;
 
   entry->net_log().AddEvent(net::NetLog::TYPE_SPARSE_DELETE_CHILDREN);
 
-  DCHECK(entry && entry->backend_);
+  DCHECK(entry->backend_);
   ChildrenDeleter* deleter = new ChildrenDeleter(entry->backend_,
                                                  entry->GetKey());
   // The object will self destruct when finished.
   deleter->AddRef();
 
   if (buffer) {
     MessageLoop::current()->PostTask(FROM_HERE, base::Bind(
         &ChildrenDeleter::Start, deleter, buffer, data_len));
   } else {
     MessageLoop::current()->PostTask(FROM_HERE, base::Bind(
@@ skipping 511 matching lines @@
     CompletionCallback cb = abort_callbacks_[i];
     if (i == abort_callbacks_.size() - 1)
       abort_callbacks_.clear();
 
     entry_->Release();  // Don't touch object after this line.
     cb.Run(net::OK);
   }
 }
 
 }  // namespace disk_cache