Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 10827379: gen-postmortem-metadata.py: fix code generator (Closed)

Created:
8 years, 4 months ago by piscisaureus
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

gen-postmortem-metadata.py: fix code generator * update tools/gen-postmortem-metadata.py * add postmortem=on switch to the Makefile Patch by Ben Noordhuis

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M Makefile View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gen-postmortem-metadata.py View 2 chunks +8 lines, -5 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
piscisaureus
PTAL
8 years, 4 months ago (2012-08-16 15:29:14 UTC) #1
piscisaureus
Added Dave Pacheco as a reviewer
8 years, 4 months ago (2012-08-16 16:17:30 UTC) #2
dave.pacheco
On 2012/08/16 16:17:30, piscisaureus wrote: > Added Dave Pacheco as a reviewer Thanks for looping ...
8 years, 4 months ago (2012-08-16 16:25:56 UTC) #3
noordhuis
On 2012/08/16 16:25:56, dave.pacheco wrote: > Thanks for looping me in, and thanks Ben for ...
8 years, 4 months ago (2012-08-16 20:13:13 UTC) #4
Michael Starzinger
Looping in Toon, who did the changes that this CL is adapting against.
8 years, 4 months ago (2012-08-16 23:33:21 UTC) #5
Toon Verwaest
Can someone clarify the context of this CL? Michael is currently on holidays and I ...
8 years, 4 months ago (2012-08-21 13:29:46 UTC) #6
noordhuis
On 2012/08/21 13:29:46, Toon Verwaest wrote: > Can someone clarify the context of this CL? ...
8 years, 3 months ago (2012-08-28 20:19:22 UTC) #7
Toon Verwaest
7 years, 6 months ago (2013-05-31 12:01:33 UTC) #8
Message was sent while issue was closed.
Marked as closed to due inactivity. Just file a new issue if there's a proper
fix (and if it's still relevant).

Powered by Google App Engine
This is Rietveld 408576698