Refactoring the SysInfoProvider.

chrome/browser/chromeos/syslogs/debugd_log_fetcher.h

Index: chrome/browser/chromeos/syslogs/debugd_log_fetcher.h
diff --git a/chrome/browser/chromeos/syslogs/debugd_log_fetcher.h b/chrome/browser/chromeos/syslogs/debugd_log_fetcher.h
new file mode 100644
index 0000000000000000000000000000000000000000..af7544be8312828bb072a761002ab45d3ffb0737
--- /dev/null
+++ b/chrome/browser/chromeos/syslogs/debugd_log_fetcher.h
@@ -0,0 +1,47 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_SYSLOGS_DEBUGD_LOG_FETCHER_H_
+#define CHROME_BROWSER_CHROMEOS_SYSLOGS_DEBUGD_LOG_FETCHER_H_
+
+#include <map>
+#include <string>
+#include <vector>
+
+#include "base/memory/weak_ptr.h"
+#include "chrome/browser/chromeos/syslogs/syslogs_fetcher.h"
+
+namespace chromeos {
+
+
+class DebugDaemonLogFetcher : public SysLogsInterface {

[satorux1, 2012/08/06 23:47:31]

class comment is missing.

[tudalex(Chromium), 2012/08/07 00:56:11]

Done.

+ public:
+  DebugDaemonLogFetcher();
+  ~DebugDaemonLogFetcher();
+
+  // Fetches logs from the daemon over dbus. After the fetch is complete, the
+  // results will be forwarded to the request supplied to the constructor and
+  // this instance will free itself.
+  void Fetch(SysLogsFetcherCallback);

[satorux1, 2012/08/06 23:47:31]

const SysLogsFetcherCallback&

[tudalex(Chromium), 2012/08/07 00:56:11]

Done.

+
+ private:
+  // Callbacks
+  void GotRoutes(bool succeeded, const std::vector<std::string>& routes);

[satorux1, 2012/08/06 23:47:31]

function comments are missing.

[tudalex(Chromium), 2012/08/07 00:56:11]

Done. Here and in other classes.

+  void GotNetworkStatus(bool succeeded, const std::string& status);
+  void GotModemStatus(bool succeeded, const std::string& status);
+  void GotLogs(bool succeeded, const std::map<std::string,std::string>& logs);
+  void RequestCompleted();
+
+  SysLogsResponse* response_;
+  SysLogsFetcherCallback request_;
+  int pending_requests_;
+  base::WeakPtrFactory<DebugDaemonLogFetcher> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(DebugDaemonLogFetcher);
+};
+
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_SYSLOGS_DEBUGD_LOG_FETCHER_H_