Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/chromeos/syslogs/debugd_log_fetcher.h

Issue 10827130: Refactoring the SysInfoProvider. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_CHROMEOS_SYSLOGS_DEBUGD_LOG_FETCHER_H_
6 #define CHROME_BROWSER_CHROMEOS_SYSLOGS_DEBUGD_LOG_FETCHER_H_
7
8 #include <map>
9 #include <string>
10 #include <vector>
11
12 #include "base/memory/weak_ptr.h"
13 #include "chrome/browser/chromeos/syslogs/syslogs_fetcher.h"
14
15 namespace chromeos {
16
17
18 class DebugDaemonLogFetcher : public SysLogsInterface {
satorux1 2012/08/06 23:47:31 class comment is missing.
tudalex(Chromium) 2012/08/07 00:56:11 Done.
19 public:
20 DebugDaemonLogFetcher();
21 ~DebugDaemonLogFetcher();
22
23 // Fetches logs from the daemon over dbus. After the fetch is complete, the
24 // results will be forwarded to the request supplied to the constructor and
25 // this instance will free itself.
26 void Fetch(SysLogsFetcherCallback);
satorux1 2012/08/06 23:47:31 const SysLogsFetcherCallback&
tudalex(Chromium) 2012/08/07 00:56:11 Done.
27
28 private:
29 // Callbacks
30 void GotRoutes(bool succeeded, const std::vector<std::string>& routes);
satorux1 2012/08/06 23:47:31 function comments are missing.
tudalex(Chromium) 2012/08/07 00:56:11 Done. Here and in other classes.
31 void GotNetworkStatus(bool succeeded, const std::string& status);
32 void GotModemStatus(bool succeeded, const std::string& status);
33 void GotLogs(bool succeeded, const std::map<std::string,std::string>& logs);
34 void RequestCompleted();
35
36 SysLogsResponse* response_;
37 SysLogsFetcherCallback request_;
38 int pending_requests_;
39 base::WeakPtrFactory<DebugDaemonLogFetcher> weak_ptr_factory_;
40
41 DISALLOW_COPY_AND_ASSIGN(DebugDaemonLogFetcher);
42 };
43
44
45 } // namespace chromeos
46
47 #endif // CHROME_BROWSER_CHROMEOS_SYSLOGS_DEBUGD_LOG_FETCHER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698