Refactoring the SysInfoProvider.

chrome/browser/chromeos/system_logs/commandline_log_source.h

Index: chrome/browser/chromeos/system_logs/commandline_log_source.h
diff --git a/chrome/browser/chromeos/system_logs/commandline_log_source.h b/chrome/browser/chromeos/system_logs/commandline_log_source.h
new file mode 100644
index 0000000000000000000000000000000000000000..5c020f0b14b3cc0363b15fc3b686e41c75584730
--- /dev/null
+++ b/chrome/browser/chromeos/system_logs/commandline_log_source.h
@@ -0,0 +1,31 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_SYSTEM_LOGS_COMMANDLINE_LOG_SOURCE_H_
+#define CHROME_BROWSER_CHROMEOS_SYSTEM_LOGS_COMMANDLINE_LOG_SOURCE_H_
+
+#include "chrome/browser/chromeos/system_logs/system_logs_fetcher.h"
+
+namespace chromeos {
+
+// It gathers logs data from various command line tools which we can not access

[satorux1, 2012/08/13 18:29:03]

Usually, we should minimize use of "it" and "this" in comments  as these can
often make comments ambiguous. Maybe:

// This class is used to gather logs data...

[tudalex(Chromium), 2012/08/14 03:24:00]

Done.

+// using Debug Daemon.
+class CommandLineLogSource : public SystemLogsSource {
+ public:
+  CommandLineLogSource() {}
+  virtual ~CommandLineLogSource() {}
+
+  // SystemLogsSource override.
+  virtual void Fetch(const SysLogsFetcherCallback& request) OVERRIDE;
+
+ private:
+  // Calls the programs and creates log entries with their output.

[satorux1, 2012/08/13 18:29:03]

What are "the programs"? Could you make it clear?

[tudalex(Chromium), 2012/08/14 03:24:00]

Reformulated it.

+  static void Execute(SystemLogsResponse* response);
+
+  DISALLOW_COPY_AND_ASSIGN(CommandLineLogSource);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_SYSTEM_LOGS_COMMANDLINE_LOG_SOURCE_H_