Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Side by Side Diff: chrome/browser/chromeos/system_logs/commandline_log_source.h

Issue 10827130: Refactoring the SysInfoProvider. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_CHROMEOS_SYSTEM_LOGS_COMMANDLINE_LOG_SOURCE_H_
6 #define CHROME_BROWSER_CHROMEOS_SYSTEM_LOGS_COMMANDLINE_LOG_SOURCE_H_
7
8 #include "chrome/browser/chromeos/system_logs/system_logs_fetcher.h"
9
10 namespace chromeos {
11
12 // It gathers logs data from various command line tools which we can not access
satorux1 2012/08/13 18:29:03 Usually, we should minimize use of "it" and "this"
tudalex(Chromium) 2012/08/14 03:24:00 Done.
13 // using Debug Daemon.
14 class CommandLineLogSource : public SystemLogsSource {
15 public:
16 CommandLineLogSource() {}
17 virtual ~CommandLineLogSource() {}
18
19 // SystemLogsSource override.
20 virtual void Fetch(const SysLogsFetcherCallback& request) OVERRIDE;
21
22 private:
23 // Calls the programs and creates log entries with their output.
satorux1 2012/08/13 18:29:03 What are "the programs"? Could you make it clear?
tudalex(Chromium) 2012/08/14 03:24:00 Reformulated it.
24 static void Execute(SystemLogsResponse* response);
25
26 DISALLOW_COPY_AND_ASSIGN(CommandLineLogSource);
27 };
28
29 } // namespace chromeos
30
31 #endif // CHROME_BROWSER_CHROMEOS_SYSTEM_LOGS_COMMANDLINE_LOG_SOURCE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698