Issue 10826196: Clean up Pipeline terminal state logic by merging kError into kStopped state.

Issue 10826196: Clean up Pipeline terminal state logic by merging kError into kStopped state. (Closed)

Created:
8 years, 4 months ago by scherkus (not reviewing)

Modified:
8 years, 4 months ago

Reviewers:
Ami GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

Clean up Pipeline terminal state logic by merging kError into kStopped state. BUG=110228

Total comments: 3

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -134 lines)			Patch
M	media/base/media_log.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	media/base/pipeline.h	View	1	7 chunks	+4 lines, -34 lines	2 comments	Download
M	media/base/pipeline.cc	View		14 chunks	+28 lines, -58 lines	0 comments	Download
M	media/base/pipeline_unittest.cc	View		17 chunks	+2 lines, -23 lines	1 comment	Download
M	webkit/media/webmediaplayer_impl.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	webkit/media/webmediaplayer_impl.cc	View		3 chunks	+4 lines, -9 lines	0 comments	Download

Total messages: 4 (0 generated)

scherkus (not reviewing)

This CL is based off of: http://codereview.chromium.org/10823222/ http://codereview.chromium.org/10855041/ ... but is orthogonal so you shouldn't ...

8 years, 4 months ago (2012-08-08 02:20:56 UTC) #1

scherkus (not reviewing)

(also I plucked the concept of this change from http://codereview.chromium.org/10828045/)

8 years, 4 months ago (2012-08-08 02:21:32 UTC) #2

scherkus (not reviewing)

hrmm... actually hold off on the review for now I want to land my unit ...

8 years, 4 months ago (2012-08-08 02:57:14 UTC) #3

scherkus (not reviewing)

8 years, 4 months ago (2012-08-09 22:34:04 UTC) #4

this CL has been superseded by:
http://codereview.chromium.org/10823261/
http://codereview.chromium.org/10825280/