Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: webkit/media/webmediaplayer_impl.h

Issue 10826196: Clean up Pipeline terminal state logic by merging kError into kStopped state. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player. 5 // Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player.
6 // It contains Pipeline which is the actual media player pipeline, it glues 6 // It contains Pipeline which is the actual media player pipeline, it glues
7 // the media player pipeline, data source, audio renderer and renderer. 7 // the media player pipeline, data source, audio renderer and renderer.
8 // Pipeline would creates multiple threads and access some public methods 8 // Pipeline would creates multiple threads and access some public methods
9 // of this class, so we need to be extra careful about concurrent access of 9 // of this class, so we need to be extra careful about concurrent access of
10 // methods and members. 10 // methods and members.
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 WebKit::WebMediaPlayer::NetworkState network_state_; 275 WebKit::WebMediaPlayer::NetworkState network_state_;
276 WebKit::WebMediaPlayer::ReadyState ready_state_; 276 WebKit::WebMediaPlayer::ReadyState ready_state_;
277 277
278 // Keep a list of buffered time ranges. 278 // Keep a list of buffered time ranges.
279 WebKit::WebTimeRanges buffered_; 279 WebKit::WebTimeRanges buffered_;
280 280
281 // Message loops for posting tasks between Chrome's main thread. Also used 281 // Message loops for posting tasks between Chrome's main thread. Also used
282 // for DCHECKs so methods calls won't execute in the wrong thread. 282 // for DCHECKs so methods calls won't execute in the wrong thread.
283 MessageLoop* main_loop_; 283 MessageLoop* main_loop_;
284 284
285 // A collection of filters.
286 scoped_ptr<media::FilterCollection> filter_collection_; 285 scoped_ptr<media::FilterCollection> filter_collection_;
287
288 // The media pipeline and a bool tracking whether we have started it yet.
289 //
290 // TODO(scherkus): replace |started_| with a pointer check for |pipeline_| and
291 // have WebMediaPlayerImpl return the default values to WebKit instead of
292 // relying on Pipeline to take care of default values.
293 scoped_refptr<media::Pipeline> pipeline_; 286 scoped_refptr<media::Pipeline> pipeline_;
294 bool started_;
295 287
296 // The currently selected key system. Empty string means that no key system 288 // The currently selected key system. Empty string means that no key system
297 // has been selected. 289 // has been selected.
298 WebKit::WebString current_key_system_; 290 WebKit::WebString current_key_system_;
299 291
300 scoped_ptr<media::MessageLoopFactory> message_loop_factory_; 292 scoped_ptr<media::MessageLoopFactory> message_loop_factory_;
301 293
302 // Playback state. 294 // Playback state.
303 // 295 //
304 // TODO(scherkus): we have these because Pipeline favours the simplicity of a 296 // TODO(scherkus): we have these because Pipeline favours the simplicity of a
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 337
346 // The decryptor that manages decryption keys and decrypts encrypted frames. 338 // The decryptor that manages decryption keys and decrypts encrypted frames.
347 ProxyDecryptor decryptor_; 339 ProxyDecryptor decryptor_;
348 340
349 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl); 341 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
350 }; 342 };
351 343
352 } // namespace webkit_media 344 } // namespace webkit_media
353 345
354 #endif // WEBKIT_MEDIA_WEBMEDIAPLAYER_IMPL_H_ 346 #endif // WEBKIT_MEDIA_WEBMEDIAPLAYER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698