Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: chrome/installer/util/shell_util.h

Issue 10826188: Sharing shell_util_unittest code to verify shortcuts (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/installer/util/shell_util.cc » ('j') | chrome/installer/util/shell_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/shell_util.h
===================================================================
--- chrome/installer/util/shell_util.h (revision 149222)
+++ chrome/installer/util/shell_util.h (working copy)
@@ -439,6 +439,15 @@
// bytes.
static string16 ByteArrayToBase32(const uint8* bytes, size_t size);
+ // Verify that a shortcut exists with expected information (for testing)
gab 2012/08/07 19:18:25 s/with/with the/ Remove "(for testing)". Add '.'
Halli 2012/08/07 20:52:16 Done.
+ // |exe_path| shortcut's exe
+ // |shortcut| path to shortcut
+ // |description| shortcut's description
+ // |icon_index| in master prefs
Halli 2012/08/07 17:16:52 I got presubmit warnings about using wide strings,
gab 2012/08/07 19:18:25 No, replace all std::wstring by string16.
gab 2012/08/07 19:18:25 |icon_index| The icon's index in the exe.
Halli 2012/08/07 20:52:16 Done.
Halli 2012/08/07 20:52:16 Done.
+ static bool VerifyChromeShortcut(const std::wstring& exe_path,
+ const std::wstring& shortcut,
gab 2012/08/07 19:18:25 ident to match variable above
Halli 2012/08/07 20:52:16 Done.
+ const std::wstring& description,
+ int icon_index);
private:
DISALLOW_COPY_AND_ASSIGN(ShellUtil);
};
« no previous file with comments | « no previous file | chrome/installer/util/shell_util.cc » ('j') | chrome/installer/util/shell_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698