Sharing shell_util_unittest code to verify shortcuts

chrome/installer/util/shell_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file declares methods that are useful for integrating Chrome in
 // Windows shell. These methods are all static and currently part of
 // ShellUtil class.
 
 #ifndef CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
 #define CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
@@ skipping 421 matching lines @@
   // should call GetCurrentInstallationSuffix().
   static bool GetOldUserSpecificRegistrySuffix(string16* suffix);
 
   // Returns the base32 encoding (using the [A-Z2-7] alphabet) of |bytes|.
   // |size| is the length of |bytes|.
   // Note: This method does not suffix the output with '=' signs as technically
   // required by the base32 standard for inputs that aren't a multiple of 5
   // bytes.
   static string16 ByteArrayToBase32(const uint8* bytes, size_t size);
 
+  // Verify that a shortcut exists with expected information (for testing)

[gab, 2012/08/07 19:18:25]

s/with/with the/

Remove "(for testing)".

Add '.' at the end.

[Halli, 2012/08/07 20:52:16]

Done.

+  // |exe_path| shortcut's exe
+  // |shortcut| path to shortcut
+  // |description| shortcut's description
+  // |icon_index| in master prefs

[Halli, 2012/08/07 17:16:52]

I got presubmit warnings about using wide strings, are they OK to use here?

[gab, 2012/08/07 19:18:25]

No, replace all std::wstring by string16.

[gab, 2012/08/07 19:18:25]

|icon_index| The icon's index in the exe.

[Halli, 2012/08/07 20:52:16]

Done.

[Halli, 2012/08/07 20:52:16]

Done.

+  static bool VerifyChromeShortcut(const std::wstring& exe_path,
+                          const std::wstring& shortcut,

[gab, 2012/08/07 19:18:25]

ident to match variable above

[Halli, 2012/08/07 20:52:16]

Done.

+                          const std::wstring& description,
+                          int icon_index);
  private:
   DISALLOW_COPY_AND_ASSIGN(ShellUtil);
 };
 
 
 #endif  // CHROME_INSTALLER_UTIL_SHELL_UTIL_H_