chrome/browser/ui/views/website_settings/website_settings_popup_view.h - Issue 10826185: Fix crash in WebsiteSettingsPopupView::OnWidgetClosing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

Issue 10826185: Fix crash in WebsiteSettingsPopupView::OnWidgetClosing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('j') | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

index ff9b206ce1e7877f3162e8ac929609c9b5c85b40..4ee832621a6e8d9e4205cf145e07c52270dacd03 100644

--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

@@ -116,7 +116,8 @@ class WebsiteSettingsPopupView

// tab.

TabContents* tab_contents_;

- // The presenter that controlls the Website Settings UI.

+ // The presenter that controlls the Website Settings UI. |presenter_| is null

+ // if the popup is opened for a internal chrome url.

scoped_ptr<WebsiteSettings> presenter_;

PopupHeaderView* header_; // Owned by views hierarchy.