chrome/browser/ui/views/website_settings/website_settings_popup_view.cc - Issue 10826185: Fix crash in WebsiteSettingsPopupView::OnWidgetClosing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Issue 10826185: Fix crash in WebsiteSettingsPopupView::OnWidgetClosing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

index 524e796ba04fd30e251e6922c1739f66c42dbc99..48aed2def7c3d6e589791355625d07fc146aac09 100644

--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

@@ -348,7 +348,8 @@ gfx::Rect WebsiteSettingsPopupView::GetAnchorRect() {

}

void WebsiteSettingsPopupView::OnWidgetClosing(views::Widget* widget) {

- presenter_->OnUIClosing();

+ if (presenter_.get())

+ presenter_->OnUIClosing();

}

void WebsiteSettingsPopupView::ButtonPressed(

« no previous file with comments | « chrome/browser/ui/views/website_settings/website_settings_popup_view.h ('k') | no next file » | no next file with comments »