Browser test for migrating from schema v0 to v1

IndexedDB browser test for migrating from leveldb schema v0 to v1.

It doesn't check that the integer version was actually added
to leveldb though, which is unfortunate.  It ensures that
opening a v0 database doesn't fail an assert, which is what
would happen if you opened an unmigrated database with code
that expects to find a stored integer version.

BUG=108223
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150458

[dgrogan, 2012-08-04 03:27:21]

Josh, could you review this?

The leveldb directory is from a clean profile that ran the
open-close-version.html layout test.

[dgrogan, 2012-08-04 03:30:39]

https://chromiumcodereview.appspot.com/10826159/diff/1/content/test/data/inde...
File content/test/data/indexeddb/migration_test.js (right):

https://chromiumcodereview.appspot.com/10826159/diff/1/content/test/data/inde...
content/test/data/indexeddb/migration_test.js:13: db = event.target.result;
I should add a line that ensures db.version is a string and not an integer.

[jsbell, 2012-08-04 03:42:30]

lgtm

http://codereview.chromium.org/10826159/diff/1/content/test/data/indexeddb/mi...
File content/test/data/indexeddb/migration_test.js (right):

http://codereview.chromium.org/10826159/diff/1/content/test/data/indexeddb/mi...
content/test/data/indexeddb/migration_test.js:13: db = event.target.result;
On 2012/08/04 03:30:39, dgrogan wrote:
> I should add a line that ensures db.version is a string and not an integer.

Agreed!

http://codereview.chromium.org/10826159/diff/1/content/test/data/indexeddb/mi...
content/test/data/indexeddb/migration_test.js:14:
shouldBe("db.objectStoreNames.length", "1");
This is to ensure that the test leveldb files were used, right? Can you add a
comment?

I can imagine in the future that we change the path used so that it isn't
"file__0.indexeddb.leveldb" so the test data isn't present and the open succeeds
but opens an empty database. Someone reading this test might not know what the
length != 1 implies without a lot of digging.

[commit-bot: I haz the power, 2012-08-07 22:13:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10826159/13002

[dgrogan, 2012-08-07 22:13:19]

http://codereview.chromium.org/10826159/diff/1/content/test/data/indexeddb/mi...
File content/test/data/indexeddb/migration_test.js (right):

http://codereview.chromium.org/10826159/diff/1/content/test/data/indexeddb/mi...
content/test/data/indexeddb/migration_test.js:13: db = event.target.result;
On 2012/08/04 03:42:30, jsbell wrote:
> On 2012/08/04 03:30:39, dgrogan wrote:
> > I should add a line that ensures db.version is a string and not an integer.
> 
> Agreed!

Done.

http://codereview.chromium.org/10826159/diff/1/content/test/data/indexeddb/mi...
content/test/data/indexeddb/migration_test.js:14:
shouldBe("db.objectStoreNames.length", "1");
On 2012/08/04 03:42:30, jsbell wrote:
> This is to ensure that the test leveldb files were used, right? Can you add a
> comment?
> 
> I can imagine in the future that we change the path used so that it isn't
> "file__0.indexeddb.leveldb" so the test data isn't present and the open
succeeds
> but opens an empty database. Someone reading this test might not know what the
> length != 1 implies without a lot of digging.

Done.

[commit-bot: I haz the power, 2012-08-07 23:53:13]

Change committed as 150458