Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1727)

Unified Diff: chrome/browser/extensions/extension_browsertest.h

Issue 10826157: Check for warnings when loading extensions in browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix existing tests Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_browsertest.h
diff --git a/chrome/browser/extensions/extension_browsertest.h b/chrome/browser/extensions/extension_browsertest.h
index 1522f73f0872c1f5062b4905d498e9cb7525fcd6..ffda8b96693b1d41a93e97c1df02edbeb6098559 100644
--- a/chrome/browser/extensions/extension_browsertest.h
+++ b/chrome/browser/extensions/extension_browsertest.h
@@ -24,6 +24,21 @@
class ExtensionBrowserTest : virtual public InProcessBrowserTest,
public content::NotificationObserver {
protected:
+ // Flags used to configure how the tests are run.
+ enum Flags {
+ kFlagNone = 0,
+
+ // Allow the extension to run in incognito mode.
+ kFlagEnableIncognito = 1 << 0,
+
+ // Allow file access for the extension.
+ kFlagEnableFileAccess = 1 << 1,
+
+ // Don't fail when the loaded manifest has warnings (should only be used
+ // when testing deprecated features).
+ kFlagIgnoreManifestWarnings = 1 << 2
+ };
+
ExtensionBrowserTest();
virtual ~ExtensionBrowserTest();
@@ -35,10 +50,8 @@ class ExtensionBrowserTest : virtual public InProcessBrowserTest,
// Same as above, but enables the extension in incognito mode first.
const extensions::Extension* LoadExtensionIncognito(const FilePath& path);
- const extensions::Extension* LoadExtensionWithOptions(
- const FilePath& path,
- bool incognito_enabled,
- bool fileaccess_enabled);
+ const extensions::Extension* LoadExtensionWithFlags(
+ const FilePath& path, int flags);
// Loads extension and imitates that it is a component extension.
const extensions::Extension* LoadExtensionAsComponent(const FilePath& path);

Powered by Google App Engine
This is Rietveld 408576698