Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/renderer/extensions/extension_helper.cc

Issue 10826141: Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: add URL parameter Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_helper.cc
diff --git a/chrome/renderer/extensions/extension_helper.cc b/chrome/renderer/extensions/extension_helper.cc
index ef75d7a474dd5b0b7206d4c25f589e1c681d2245..80695e2b7b39ef79efe269dea0dbc4946e92882d 100644
--- a/chrome/renderer/extensions/extension_helper.cc
+++ b/chrome/renderer/extensions/extension_helper.cc
@@ -345,7 +345,7 @@ void ExtensionHelper::OnExecuteCode(
if (!main_frame) {
ListValue val;
Send(new ExtensionHostMsg_ExecuteCodeFinished(
- routing_id(), params.request_id, false, -1, "", val));
+ routing_id(), params.request_id, "No main frame", -1, GURL(""), val));
Jeffrey Yasskin 2012/08/06 11:39:02 Yay for actual error messages. :)
return;
}

Powered by Google App Engine
This is Rietveld 408576698