Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and

chrome/renderer/extensions/extension_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/extension_helper.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/json/json_string_value_serializer.h"
@@ skipping 327 matching lines @@
       render_view());
 }
 
 void ExtensionHelper::OnExecuteCode(
     const ExtensionMsg_ExecuteCode_Params& params) {
   WebView* webview = render_view()->GetWebView();
   WebFrame* main_frame = webview->mainFrame();
   if (!main_frame) {
     ListValue val;
     Send(new ExtensionHostMsg_ExecuteCodeFinished(
-        routing_id(), params.request_id, false, -1, "", val));
+        routing_id(), params.request_id, "No main frame", -1, GURL(""), val));

[Jeffrey Yasskin, 2012/08/06 11:39:02]

Yay for actual error messages. :)

     return;
   }
 
   // chrome.tabs.executeScript() only supports execution in either the top frame
   // or all frames.  We handle both cases in the top frame.
   SchedulerMap::iterator i = g_schedulers.Get().find(main_frame);
   if (i != g_schedulers.Get().end())
     i->second->ExecuteCode(params);
 }
 
@@ skipping 151 matching lines @@
         target_level = WebConsoleMessage::LevelWarning;
         break;
       case content::CONSOLE_MESSAGE_LEVEL_ERROR:
         target_level = WebConsoleMessage::LevelError;
         break;
     }
     render_view()->GetWebView()->mainFrame()->addMessageToConsole(
         WebConsoleMessage(target_level, message));
   }
 }