Inactive user toast. Set chrome as default.

Inactive user toast. Set chrome as default.

BUG=129499
TEST=see bug
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149941

[grt (UTC plus 2), 2012-08-02 08:41:10]

http://codereview.chromium.org/10826108/diff/1/chrome/browser/chrome_browser_...
File chrome/browser/chrome_browser_main.cc (right):

http://codereview.chromium.org/10826108/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main.cc:1368:
ShellIntegration::SetAsDefaultBrowser();
if you want the Greg dialog to appear on Win8, this needs to be:

switch (ShellIntegration::CanSetAsDefaultBrowser()) {
  case ShellIntegration::SET_DEFAULT_UNATTENDED:
    ShellIntegration::SetAsDefaultBrowser();
    break;
  case ShellIntegration::SET_DEFAULT_INTERACTIVE:
    ShellIntegration::SetAsDefaultBrowserInteractive();
    break;
  default:
    DCHECK_EQ(ShellIntegration::CanSetAsDefaultBrowser(),
              ShellIntegration::SET_DEFAULT_NOT_ALLOWED);
    break;
}

if you don't want to put that logic here, it could be rolled into
ShellIntegration somehow.  if you choose to do that, it's not obvious to me that
all callers of SetAsDefaultBrowser() want the interactive path if the unattended
isn't available.

[cpu_(ooo_6.6-7.5), 2012-08-02 23:25:20]

please take a look again.

http://codereview.chromium.org/10826108/diff/1/chrome/browser/chrome_browser_...
File chrome/browser/chrome_browser_main.cc (right):

http://codereview.chromium.org/10826108/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main.cc:1368:
ShellIntegration::SetAsDefaultBrowser();
Good to know. No, I don't want the win8 case.

I will do a patch that disables experiments for that os.

On 2012/08/02 08:41:10, grt wrote:
> if you want the Greg dialog to appear on Win8, this needs to be:
> 
> switch (ShellIntegration::CanSetAsDefaultBrowser()) {
>   case ShellIntegration::SET_DEFAULT_UNATTENDED:
>     ShellIntegration::SetAsDefaultBrowser();
>     break;
>   case ShellIntegration::SET_DEFAULT_INTERACTIVE:
>     ShellIntegration::SetAsDefaultBrowserInteractive();
>     break;
>   default:
>     DCHECK_EQ(ShellIntegration::CanSetAsDefaultBrowser(),
>               ShellIntegration::SET_DEFAULT_NOT_ALLOWED);
>     break;
> }
> 
> if you don't want to put that logic here, it could be rolled into
> ShellIntegration somehow.  if you choose to do that, it's not obvious to me
that
> all callers of SetAsDefaultBrowser() want the interactive path if the
unattended
> isn't available.

[robertshield, 2012-08-03 20:40:05]

lgtm

http://codereview.chromium.org/10826108/diff/4001/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_main.cc (right):

http://codereview.chromium.org/10826108/diff/4001/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main.cc:1368: // Only set in the unatendeded case,
the interactive case is Windows 8.
nit: unatendedededed -> unattended