Inactive user toast. Set chrome as default.

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 1345 matching lines @@
       return TryChromeDialogView::NOT_NOW;
     }
     int try_chrome_int;
     base::StringToInt(try_chrome, &try_chrome_int);
     TryChromeDialogView::Result answer =
         TryChromeDialogView::Show(try_chrome_int, process_singleton_.get());
     if (answer == TryChromeDialogView::NOT_NOW)
       return chrome::RESULT_CODE_NORMAL_EXIT_CANCEL;
     if (answer == TryChromeDialogView::UNINSTALL_CHROME)
       return chrome::RESULT_CODE_NORMAL_EXIT_EXP2;
+    // At this point the user is willing to try chrome again.
+    if (answer == TryChromeDialogView::TRY_CHROME_AS_DEFAULT)
+      ShellIntegration::SetAsDefaultBrowser();

[grt (UTC plus 2), 2012/08/02 08:41:10]

if you want the Greg dialog to appear on Win8, this needs to be:

switch (ShellIntegration::CanSetAsDefaultBrowser()) {
  case ShellIntegration::SET_DEFAULT_UNATTENDED:
    ShellIntegration::SetAsDefaultBrowser();
    break;
  case ShellIntegration::SET_DEFAULT_INTERACTIVE:
    ShellIntegration::SetAsDefaultBrowserInteractive();
    break;
  default:
    DCHECK_EQ(ShellIntegration::CanSetAsDefaultBrowser(),
              ShellIntegration::SET_DEFAULT_NOT_ALLOWED);
    break;
}

if you don't want to put that logic here, it could be rolled into
ShellIntegration somehow.  if you choose to do that, it's not obvious to me that
all callers of SetAsDefaultBrowser() want the interactive path if the unattended
isn't available.

[cpu_(ooo_6.6-7.5), 2012/08/02 23:25:20]

Good to know. No, I don't want the win8 case.

I will do a patch that disables experiments for that os.

On 2012/08/02 08:41:10, grt wrote:

 #else
     // We don't support retention experiments on Mac or Linux.
     return content::RESULT_CODE_NORMAL_EXIT;
 #endif  // defined(OS_WIN)
   }
 
   // On first run, we need to process the predictor preferences before the
   // browser's profile_manager object is created, but after ResourceBundle
   // is initialized.
   first_run_ui_bypass_ = false;  // True to skip first run UI.
@@ skipping 704 matching lines @@
     if (base::win::GetVersion() <= base::win::VERSION_XP)
       uma_name += "_XP";
 
     uma_name += "_PreRead_";
     uma_name += pre_read_percentage;
     AddPreReadHistogramTime(uma_name.c_str(), time);
   }
 #endif
 #endif
 }