Fixing problems with constrained windows (i.e. print preview)

ash/wm/frame_painter.cc

Index: ash/wm/frame_painter.cc
diff --git a/ash/wm/frame_painter.cc b/ash/wm/frame_painter.cc
index 2c0a43c30a97e3ac3bde5d62c604c4b4a85a9550..b24aa15ca4cff1b3849a88c08654a0d2cc294c0e 100644
--- a/ash/wm/frame_painter.cc
+++ b/ash/wm/frame_painter.cc
@@ -609,7 +609,11 @@ bool FramePainter::UseSoloWindowHeader() {
   for (std::set<FramePainter*>::const_iterator it = instances_->begin();
        it != instances_->end();
        ++it) {
-    if (IsVisibleNormalWindow((*it)->window_)) {
+    // The window needs to be a 'normal window'. To exclude constrained windows
+    // the existence of a layout manager gets additionally tested.
+    if (IsVisibleNormalWindow((*it)->window_) &&
+        (!(*it)->window_->parent() ||
+         (*it)->window_->parent()->layout_manager())) {

[Ben Goodger (Google), 2012/07/31 17:59:35]

hrm... this seems like it could be brittle, for example if we were to add a
layout manager to chrome windows somehow.

It seems like we should have a function somewhere, maybe in ash/wm/window_util.h
that determines if a window is a direct descendent of one of the window
containers (default or always-on-top containers). you could add that function
and call it here instead of doing this.

[Mr4D (OOO till 08-26), 2012/07/31 19:37:26]

I added a property flag which seems to be a better way to do it. (as discussed).

       window_count++;
       if (window_count > 1)
         return false;