Fixing problems with constrained windows (i.e. print preview)

ash/wm/frame_painter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/frame_painter.h"
 
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/wm/window_util.h"
 #include "base/logging.h"  // DCHECK
@@ skipping 591 matching lines @@
     return kActiveWindowOpacity;
   return kInactiveWindowOpacity;
 }
 
 // static
 bool FramePainter::UseSoloWindowHeader() {
   int window_count = 0;
   for (std::set<FramePainter*>::const_iterator it = instances_->begin();
        it != instances_->end();
        ++it) {
-    if (IsVisibleNormalWindow((*it)->window_)) {
+    // The window needs to be a 'normal window'. To exclude constrained windows
+    // the existence of a layout manager gets additionally tested.
+    if (IsVisibleNormalWindow((*it)->window_) &&
+        (!(*it)->window_->parent() ||
+         (*it)->window_->parent()->layout_manager())) {

[Ben Goodger (Google), 2012/07/31 17:59:35]

hrm... this seems like it could be brittle, for example if we were to add a
layout manager to chrome windows somehow.

It seems like we should have a function somewhere, maybe in ash/wm/window_util.h
that determines if a window is a direct descendent of one of the window
containers (default or always-on-top containers). you could add that function
and call it here instead of doing this.

[Mr4D (OOO till 08-26), 2012/07/31 19:37:26]

I added a property flag which seems to be a better way to do it. (as discussed).

       window_count++;
       if (window_count > 1)
         return false;
     }
   }
   return window_count == 1;
 }
 
 // static
 void FramePainter::SchedulePaintForSoloWindow() {
   for (std::set<FramePainter*>::const_iterator it = instances_->begin();
        it != instances_->end();
        ++it) {
     FramePainter* painter = *it;
     if (IsVisibleNormalWindow(painter->window_))
       painter->frame_->non_client_view()->SchedulePaint();
   }
 }
 
 }  // namespace ash