Start of New Autofill UI for Windows

chrome/browser/ui/views/autofill/autofill_external_delegate_views.cc

Index: chrome/browser/ui/views/autofill/autofill_external_delegate_views.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_external_delegate_views.cc b/chrome/browser/ui/views/autofill/autofill_external_delegate_views.cc
new file mode 100644
index 0000000000000000000000000000000000000000..160b8024747238aaff31934e9f1a7f40879c82a7
--- /dev/null
+++ b/chrome/browser/ui/views/autofill/autofill_external_delegate_views.cc
@@ -0,0 +1,61 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/autofill/autofill_external_delegate_views.h"
+
+#include "chrome/browser/ui/views/autofill/autofill_popup_view_views.h"
+
+AutofillExternalDelegate* AutofillExternalDelegate::Create(
+    TabContents* tab_contents,
+    AutofillManager* autofill_manager) {
+  return new AutofillExternalDelegateViews(tab_contents, autofill_manager);
+}
+
+AutofillExternalDelegateViews::AutofillExternalDelegateViews(
+    TabContents* tab_contents,
+    AutofillManager* autofill_manager)
+    : AutofillExternalDelegate(tab_contents, autofill_manager) {
+}
+
+AutofillExternalDelegateViews::~AutofillExternalDelegateViews() {
+}
+
+void AutofillExternalDelegateViews::HideAutofillPopupInternal() {
+  if (!view_.get())
+    return;
+
+  view_->Hide();

[sky, 2012/08/15 21:07:29]

Why do you need hide here?

[csharp, 2012/08/16 19:16:27]

Without this hide the popup doesn't disappear (since we are only holding the
weak pointer to it the reset doesn't delete the object)

[sky, 2012/08/16 20:00:15]

You're saying the Hide deletes? Doesn't it eventually end up in
AutofillPopupViewViews::HideInternal() which does SetVisible(false)? 
AutofillPopupViewViews is a View, so SetVisible(false) on the view just hides
the view not the widget. Maybe I'm missing something?

[csharp, 2012/08/16 21:39:15]

I think you've got it right. This will lead to the view getting hidden while the
widget remains visible.

I've update AutofillPopupViewViews::HideInternal() to also hide the widget. Is
this right?

+  view_.reset();
+}
+
+void AutofillExternalDelegateViews::OnQueryPlatformSpecific(
+    int query_id,
+    const webkit::forms::FormData& form,
+    const webkit::forms::FormField& field,
+    const gfx::Rect& bounds) {
+  CreateViewIfNeeded();
+  view_->set_element_bounds(bounds);
+}
+
+void AutofillExternalDelegateViews::ApplyAutofillSuggestions(
+    const std::vector<string16>& autofill_values,
+    const std::vector<string16>& autofill_labels,
+    const std::vector<string16>& autofill_icons,
+    const std::vector<int>& autofill_unique_ids) {
+  CreateViewIfNeeded();
+
+  view_->Show(autofill_values,
+              autofill_labels,
+              autofill_icons,
+              autofill_unique_ids);
+}
+
+void AutofillExternalDelegateViews::SetBounds(const gfx::Rect& bounds) {
+  view_->SetBoundsRect(bounds);
+}
+
+void AutofillExternalDelegateViews::CreateViewIfNeeded() {
+  if (!view_.get())
+    view_.reset(new AutofillPopupViewViews(web_contents(), this));
+}