Start of New Autofill UI for Windows

chrome/browser/ui/views/autofill/autofill_external_delegate_views.h

Index: chrome/browser/ui/views/autofill/autofill_external_delegate_views.h
diff --git a/chrome/browser/ui/views/autofill/autofill_external_delegate_views.h b/chrome/browser/ui/views/autofill/autofill_external_delegate_views.h
new file mode 100644
index 0000000000000000000000000000000000000000..b3f71314e6a65014e6be541887b29c72fd726f2d
--- /dev/null
+++ b/chrome/browser/ui/views/autofill/autofill_external_delegate_views.h
@@ -0,0 +1,48 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_VIEWS_H_
+#define CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_VIEWS_H_
+
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/autofill/autofill_external_delegate.h"
+
+class AutofillPopupViewViews;
+
+namespace content {
+class WebContents;
+}
+
+class AutofillExternalDelegateViews : public AutofillExternalDelegate {

[sky, 2012/08/15 21:07:29]

Add a dscription.

[csharp, 2012/08/16 19:16:27]

Done.

+ public:
+  AutofillExternalDelegateViews(TabContents* tab_contents,
+                                AutofillManager* autofill_manager);
+
+  virtual ~AutofillExternalDelegateViews();
+
+ private:
+  // AutofillExternalDelegate implementation.
+  virtual void HideAutofillPopupInternal() OVERRIDE;
+  virtual void OnQueryPlatformSpecific(
+      int query_id,
+      const webkit::forms::FormData& form,
+      const webkit::forms::FormField& field,
+      const gfx::Rect& bounds) OVERRIDE;
+  virtual void ApplyAutofillSuggestions(
+      const std::vector<string16>& autofill_values,
+      const std::vector<string16>& autofill_labels,
+      const std::vector<string16>& autofill_icons,
+      const std::vector<int>& autofill_unique_ids) OVERRIDE;
+  virtual void SetBounds(const gfx::Rect& bounds) OVERRIDE;
+
+  // Create a valid view to display the autofill results if one doesn't
+  // currently exist.
+  void CreateViewIfNeeded();
+
+  scoped_ptr<AutofillPopupViewViews> view_;

[sky, 2012/08/15 21:07:29]

This is fragile. AutofillPopupViewViews is deleted by either the view hierarchy
(because its a child of the popup) or here. I think this code would be less
fragile if AutofillPopupViewViews was not the actual AutofillPopupView.

[csharp, 2012/08/16 19:16:27]

I'm not sure I understand how to fix that. If AutofillPopupViewViews isn't the
actual popup, then who is (And wouldn't this new popup have the same issue).

[sky, 2012/08/16 20:00:15]

I'm not sure what you mean by popup here (too many popups). IF you need to deal
with two places possibly deleting the object then it seems like you need a way
for the popup to tell you its deleted so that this can release the object.

[csharp, 2012/08/16 21:39:15]

Ok, I've added code for the popup to let the delegate know if it has been
deleted. I'm just holding it as a raw pointer right now since none of the other
types seem like they would work in this situation. Is there a class I should be
using to hold that pointer?

+
+  DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegateViews);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_VIEWS_H_