chrome/browser/chromeos/gdata/gdata_file_system.cc - Issue 10825218: Simplify implementation of FindEntryByPathSync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/gdata/gdata_file_system.cc

Issue 10825218: Simplify implementation of FindEntryByPathSync (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: remove FindChildAsync 2 Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/gdata/gdata_file_system.cc

===================================================================

--- chrome/browser/chromeos/gdata/gdata_file_system.cc (revision 150246)

+++ chrome/browser/chromeos/gdata/gdata_file_system.cc (working copy)

@@ -2866,8 +2866,7 @@

*resource_id = entry->AsGDataFile()->resource_id();

GDataDirectory* parent_dir = entry->parent();

- if (!parent_dir->RemoveEntry(entry))

- return GDATA_FILE_ERROR_NOT_FOUND;

+ parent_dir->RemoveEntry(entry);

satorux1 2012/08/07 22:27:05 Is this a good thing to do? I think removing an no

achuithb 2012/08/07 22:28:32 We already look up the entry using FindEntryByPath

satorux1 2012/08/07 22:38:09 Ah that's a good point.

FOR_EACH_OBSERVER(GDataFileSystemInterface::Observer, observers_,

OnDirectoryChanged(parent_dir->GetFilePath()));