Simplify implementation of FindEntryByPathSync

chrome/browser/chromeos/gdata/gdata_file_system.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_file_system.h"
 
 #include <set>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 2848 matching lines @@
   // You can't remove root element.
   if (!entry->parent())
     return GDATA_FILE_ERROR_ACCESS_DENIED;
 
   // If it's a file (only files have resource id), get its resource id so that
   // we can remove it after releasing the auto lock.
   if (entry->AsGDataFile())
     *resource_id = entry->AsGDataFile()->resource_id();
 
   GDataDirectory* parent_dir = entry->parent();
-  if (!parent_dir->RemoveEntry(entry))
-    return GDATA_FILE_ERROR_NOT_FOUND;
+  parent_dir->RemoveEntry(entry);

[satorux1, 2012/08/07 22:27:05]

Is this a good thing to do? I think removing an non-existent entry should result
in GDATA_FILE_ERROR_NOT_FOUND

[achuithb, 2012/08/07 22:28:32]

We already look up the entry using FindEntryByPathSync at line 2854. I don't
think this redundant check adds any value.

[satorux1, 2012/08/07 22:38:09]

Ah that's a good point.

 
   FOR_EACH_OBSERVER(GDataFileSystemInterface::Observer, observers_,
                     OnDirectoryChanged(parent_dir->GetFilePath()));
   return GDATA_FILE_OK;
 }
 
 void GDataFileSystem::AddUploadedFile(
     UploadMode upload_mode,
     const FilePath& virtual_dir_path,
     scoped_ptr<DocumentEntry> entry,
@@ skipping 544 matching lines @@
   }
 
   PlatformFileInfoProto entry_file_info;
   GDataEntry::ConvertPlatformFileInfoToProto(*file_info, &entry_file_info);
   *entry_proto->mutable_file_info() = entry_file_info;
   if (!callback.is_null())
     callback.Run(GDATA_FILE_OK, entry_proto.Pass());
 }
 
 }  // namespace gdata