Extensions Docs Server: Apps samples page

chrome/common/extensions/docs/server2/api_data_source_test.py

Index: chrome/common/extensions/docs/server2/api_data_source_test.py
diff --git a/chrome/common/extensions/docs/server2/api_data_source_test.py b/chrome/common/extensions/docs/server2/api_data_source_test.py
index 253b084df3239bd025af0faef6fa424cc7336f0f..9fff33eee86563f25a1efda0966bd6d4c78f6152 100755
--- a/chrome/common/extensions/docs/server2/api_data_source_test.py
+++ b/chrome/common/extensions/docs/server2/api_data_source_test.py
@@ -33,9 +33,15 @@ class APIDataSourceTest(unittest.TestCase):
     # Take the dict out of the list.
     expected = json.loads(self._ReadLocalFile('expected_test_file.json'))
     expected['permissions'] = None
-    self.assertEqual(expected, data_source['test_file'])
-    self.assertEqual(expected, data_source['testFile'])
-    self.assertEqual(expected, data_source['testFile.html'])
+    test1 = data_source['test_file']
+    test1.pop('samples')

[not at google - send to devlin, 2012/08/10 06:02:18]

Why not just add the samples to the expected data? You know what it's supposed
to be (since you're controlling it in FakeSamplesDataSource).

[cduvall, 2012/08/10 21:17:47]

The samples isn't actually a SamplesDataSource, its a _LazySamplesGetter. This
makes it so the test will fail, because the expected JSON doesn't have a
_LazySamplesGetter.

[not at google - send to devlin, 2012/08/13 01:51:11]

Ah I see.

Could you define __eq__ for Future, which compares values? Make
FakeSamplesDataSource return a Future(value={})? It would be really nice to
compare to the real result.

[not at google - send to devlin, 2012/08/13 22:39:09]

(sorry about this comment, my brain did s/_LazySamplesGetter/Future/ without
warning me)

+    self.assertEqual(expected, test1)
+    test2 = data_source['testFile']
+    test2.pop('samples')
+    self.assertEqual(expected, test2)
+    test3 = data_source['testFile.html']
+    test3.pop('samples')
+    self.assertEqual(expected, test3)
     self.assertRaises(OSError, data_source.get, 'junk')
 
 if __name__ == '__main__':