Extensions Docs Server: Apps samples page

chrome/common/extensions/docs/server2/api_data_source_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import os
 import unittest
 
 from file_system_cache import FileSystemCache
@@ skipping 15 matching lines @@
   def testSimple(self):
     cache_builder = FileSystemCache.Builder(LocalFileSystem(self._base_path))
     data_source_factory = APIDataSource.Factory(cache_builder,
                                                 './',
                                                 FakeSamplesDataSource())
     data_source = data_source_factory.Create({})
 
     # Take the dict out of the list.
     expected = json.loads(self._ReadLocalFile('expected_test_file.json'))
     expected['permissions'] = None
-    self.assertEqual(expected, data_source['test_file'])
-    self.assertEqual(expected, data_source['testFile'])
-    self.assertEqual(expected, data_source['testFile.html'])
+    test1 = data_source['test_file']
+    test1.pop('samples')

[not at google - send to devlin, 2012/08/10 06:02:18]

Why not just add the samples to the expected data? You know what it's supposed
to be (since you're controlling it in FakeSamplesDataSource).

[cduvall, 2012/08/10 21:17:47]

The samples isn't actually a SamplesDataSource, its a _LazySamplesGetter. This
makes it so the test will fail, because the expected JSON doesn't have a
_LazySamplesGetter.

[not at google - send to devlin, 2012/08/13 01:51:11]

Ah I see.

Could you define __eq__ for Future, which compares values? Make
FakeSamplesDataSource return a Future(value={})? It would be really nice to
compare to the real result.

[not at google - send to devlin, 2012/08/13 22:39:09]

(sorry about this comment, my brain did s/_LazySamplesGetter/Future/ without
warning me)

+    self.assertEqual(expected, test1)
+    test2 = data_source['testFile']
+    test2.pop('samples')
+    self.assertEqual(expected, test2)
+    test3 = data_source['testFile.html']
+    test3.pop('samples')
+    self.assertEqual(expected, test3)
     self.assertRaises(OSError, data_source.get, 'junk')
 
 if __name__ == '__main__':
   unittest.main()