Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 10824387: Implement forwarding of search queries for metro mode (Closed)

Created:
8 years, 4 months ago by cpu_(ooo_6.6-7.5)
Modified:
8 years, 4 months ago
Reviewers:
iyengar, brettw, ananta
CC:
chromium-reviews, tfarina, erikwright+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Implement forwarding of search queries for metro mode If chrome is the default browser, launch from the search charm does not use the delegate_execute so if desktop chrome is running, metro chrome needs to forward the search string and quickly quite The source of complexity here is that to form the full url, chrome needs to access the profile which cannot be done from the metro chrome since the desktop chrome has the profile locked. Instead we leveage the kMetroNavigationAndSearchMessage from the singleton code. BUG=141032 TEST= see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152818

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -48 lines) Patch
M base/win/metro.h View 1 2 3 2 chunks +11 lines, -6 lines 0 comments Download
M base/win/metro.cc View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 2 3 5 chunks +38 lines, -9 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_win.cc View 1 2 3 2 chunks +8 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cpu_(ooo_6.6-7.5)
Brett, changes in base. Iyengar: all.
8 years, 4 months ago (2012-08-20 21:29:10 UTC) #1
ananta
http://codereview.chromium.org/10824387/diff/1/chrome/browser/ui/views/frame/browser_frame_win.cc File chrome/browser/ui/views/frame/browser_frame_win.cc (right): http://codereview.chromium.org/10824387/diff/1/chrome/browser/ui/views/frame/browser_frame_win.cc#newcode509 chrome/browser/ui/views/frame/browser_frame_win.cc:509: wchar_t atom[128] = {0}; Instead of hardcoding the atom ...
8 years, 4 months ago (2012-08-20 21:40:48 UTC) #2
brettw
LGTM rubberstamp for base, leaving real review for Ananta.
8 years, 4 months ago (2012-08-20 22:03:13 UTC) #3
cpu_(ooo_6.6-7.5)
Ananta, look again at the singleton part. I harcoded the url for the time being.
8 years, 4 months ago (2012-08-21 18:28:35 UTC) #4
ananta
8 years, 4 months ago (2012-08-22 20:58:45 UTC) #5
lgtm

http://codereview.chromium.org/10824387/diff/13002/chrome/browser/process_sin...
File chrome/browser/process_singleton_win.cc (right):

http://codereview.chromium.org/10824387/diff/13002/chrome/browser/process_sin...
chrome/browser/process_singleton_win.cc:123: BOOL CALLBACK TopWindowFinder(HWND
hwnd, LPARAM result) {
This function is not used anymore. Please delete it.

Powered by Google App Engine
This is Rietveld 408576698