Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 10824386: Add SetScale to PPB_WidgetDev, use scale for painting (Closed)

Created:
8 years, 4 months ago by Josh Horwich
Modified:
8 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Add SetScale to PPB_WidgetDev, use scale for painting In order to allow for HiDPI-aware scrollbars, this patch allows the plugin to specify a scale factor used during widget paint operations. The widgets (of which Scrollbar is the only current instance) will continue to use the DIP coordinate system for events and sizing, which is consistent with their WebKit implementation. This change should maintain backward compat. with existing users of interface 'PPB_Wdiget(Dev);0.3' BUG=140833 TEST=Run pre-built (with 0.3 interfaces) PDF plugin and verify scrollbars Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152495 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -25 lines) Patch
M ppapi/api/dev/ppb_widget_dev.idl View 2 chunks +9 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_widget_dev.h View 4 chunks +19 lines, -4 lines 0 comments Download
M ppapi/cpp/dev/widget_dev.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/cpp/dev/widget_dev.cc View 2 chunks +42 lines, -17 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/ppb_widget_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/ppb_widget_thunk.cc View 2 chunks +21 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_scrollbar_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_widget_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_widget_impl.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Josh Horwich
Please take a look.
8 years, 4 months ago (2012-08-20 22:28:59 UTC) #1
brettw
lgtm
8 years, 4 months ago (2012-08-20 23:31:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhorwich@chromium.org/10824386/1
8 years, 4 months ago (2012-08-21 00:34:09 UTC) #3
commit-bot: I haz the power
Change committed as 152495
8 years, 4 months ago (2012-08-21 02:51:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhorwich@chromium.org/10824386/1
8 years, 4 months ago (2012-08-22 22:40:34 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-23 00:47:56 UTC) #6
Change committed as 152889

Powered by Google App Engine
This is Rietveld 408576698