Disable compiler option 'mimplicit-it' for Android ARM

breakpad/breakpad.gyp

Index: breakpad/breakpad.gyp
diff --git a/breakpad/breakpad.gyp b/breakpad/breakpad.gyp
index cbed22c90944dbac59b68b27b55e9c7d3f7366e5..1e4a347f104acb02f3815147106e0370707b1fbf 100644
--- a/breakpad/breakpad.gyp
+++ b/breakpad/breakpad.gyp
@@ -530,6 +530,8 @@
                 'src/common/linux/elf_core_dump.cc',
                 'src/common/linux/elf_core_dump.h',
               ],
+              # Android NDK toolchain doesn't support it

[Mark Mentovai, 2012/08/16 12:34:59]

It? What?

[yongsheng, 2012/08/17 01:35:33]

yes, See the message:
Assembler messages:
Error: unrecognized option -mimplicit-it=always

[Mark Mentovai, 2012/08/17 14:04:00]

yongsheng wrote:
I understand. I’m saying that your comment isn’t clear. It says “Android NDK
toolchain doesn’t support it,” and when I read that comment, I say “it? what?
what ‘it’ are you talking about?”

If it doesn’t support -mimplicit-it, the comment should say so.

# The Android NDK toolchain doesn't support -mimplicit-it.

You referred me to a similar line in common.gypi, which has a much better
comment (more like the one I’m proposing.)

+              'cflags!': ['-Wa,-mimplicit-it=always'],
             }],
           ],