Disable compiler option 'mimplicit-it' for Android ARM

breakpad/breakpad.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
     'breakpad_sender.gypi',
     'breakpad_handler.gypi',
   ],
   'conditions': [
@@ skipping 504 matching lines @@
             'src/common/linux/memory_mapped_file.cc',
             'src/common/linux/memory_mapped_file.h',
             'src/common/linux/safe_readlink.cc',
             'src/common/linux/safe_readlink.h',
             'src/common/memory.h',
             'src/common/string_conversion.cc',
             'src/common/string_conversion.h',
           ],
 
           'conditions': [
             ['target_arch=="arm"', {

[Mark Mentovai, 2012/08/16 12:34:59]

Make this target_arch=="arm" && OS!="android" instead.

[yongsheng, 2012/08/17 01:35:33]

ok

               'cflags': ['-Wa,-mimplicit-it=always'],
             }],
             ['OS=="android"', {
               'sources!':[
                 'src/common/linux/elf_core_dump.cc',
                 'src/common/linux/elf_core_dump.h',
               ],
+              # Android NDK toolchain doesn't support it

[Mark Mentovai, 2012/08/16 12:34:59]

It? What?

[yongsheng, 2012/08/17 01:35:33]

yes, See the message:
Assembler messages:
Error: unrecognized option -mimplicit-it=always

[Mark Mentovai, 2012/08/17 14:04:00]

yongsheng wrote:
I understand. I’m saying that your comment isn’t clear. It says “Android NDK
toolchain doesn’t support it,” and when I read that comment, I say “it? what?
what ‘it’ are you talking about?”

If it doesn’t support -mimplicit-it, the comment should say so.

# The Android NDK toolchain doesn't support -mimplicit-it.

You referred me to a similar line in common.gypi, which has a much better
comment (more like the one I’m proposing.)

+              'cflags!': ['-Wa,-mimplicit-it=always'],
             }],
           ],
 
           'link_settings': {
             'libraries': [
               '-ldl',
             ],
           },
 
           'include_dirs': [
@@ skipping 210 matching lines @@
           'include_dirs': [
             'src',
             'src/client/mac/Framework',
             'src/common/mac',
           ],
         },
       ],
     }],
   ],
 }